Переглянути джерело

Revert "explain why default role cannot be admin"

This reverts commit e518756aa51f8f7e2cf60506f5785c8a6ca39c9a.
Girish Ramakrishnan 6 роки тому
батько
коміт
adc69834b4
1 змінених файлів з 4 додано та 3 видалено
  1. 4 3
      start.sh

+ 4 - 3
start.sh

@@ -128,9 +128,10 @@ if [[ -n "${LDAP_SERVER:-}" ]]; then
     # configure LDAP
     # https://github.com/heiglandreas/authLdap/blob/master/authLdap.php#L644
 
-    # GroupEnable means that ldap groups are carried over to wp groups
+    # GroupEnable means that cloudron groups are carried over to wp groups
     # GroupOverUser means that if there is an existing wp group for the user, it won't be overwritten
-    # The default role is 'editor' and not 'admin' because normal users can otherwise install plugins/thus modify code
+    # The above implies that users can override the roles in wordpress and it
+    # doesn't get overwritten on re-login
     echo "Configuring LDAP"
     ldapConfig=$(cat <<EOF
     {
@@ -149,7 +150,7 @@ if [[ -n "${LDAP_SERVER:-}" ]]; then
         "GroupAttr"     : "memberof",
         "GroupFilter"   : "(|(mail=%1\$s)(username=%1\$s))",
         "DefaultRole"   : "editor",
-        "GroupEnable"   : false,
+        "GroupEnable"   : true,
         "GroupOverUser" : false,
         "Version"       : 1
     }